Fix: Use npm ci on lint GitHub Action
#197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
npm installmay potentially make modifications to the contents ofpackage-lock.json. One scenario where this may occur is when the version of npm on the GitHub Actionubuntu-latestimage differs from the version used locally. Combined with thegit-auto-commit-action, this can then lead to the linter inadvertently committing changes to package-lock.json as a side-effect ofnpm install.Fix
Use
npm ci, which will not make any changes topackage-lock.json, and is what is recommended to use in GitHub Actions regardless.