-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Where doesnt have nullable morph #54363
Open
liamduckett
wants to merge
10
commits into
laravel:11.x
Choose a base branch
from
liamduckett:where-doesnt-have-nullable-morph
base: 11.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[11.x] Where doesnt have nullable morph #54363
liamduckett
wants to merge
10
commits into
laravel:11.x
from
liamduckett:where-doesnt-have-nullable-morph
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
requested changes
Jan 28, 2025
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
liamduckett
force-pushed
the
where-doesnt-have-nullable-morph
branch
from
January 29, 2025 20:49
bbcc7ef
to
28e67ef
Compare
liamduckett
force-pushed
the
where-doesnt-have-nullable-morph
branch
from
January 29, 2025 20:50
28e67ef
to
02b7f76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this PR aims to resolve this issue.
The problem currently (as described in the issue) is that
QueriesRelationships::
excludes Models with anull
morph_type
value.This is due to the logic in
QueriesRelationships::hasMorph
revolving aroundtypes
(which exludesnull
):My proposed solution adds a conditional clause to the query, to also include models with a
null
morph relation. I made the decision to widen the scope to include other operators - as this felt more complete of a solution than just solving for defaultwhereDoesntHave
. I understand this comes with it's own drawbacks, and am happy to partly undo if desired.This only applies if the chosen
type
is wildcard, as I understand choosing types currently means any results must have that type of morph relation (and naturally,null
cannot acheieve this). Truthfully I'm not particularily confident on this bit - would appreciate any checking over!I've only added the test case from the issue, as it feels like the majority use case.
Please see my logic for deciding which operators to include below.