feat(Checkout): Add request option parameters #1730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 8, 2025 11:42
-Add $opts parameter to Checkout and CheckoutBuilder classes -Allow custom request options to be passed when creating Checkouts -Add type import comments for PHPStan and Psalm
driesvints
reviewed
Jan 8, 2025
driesvints
reviewed
Jan 8, 2025
driesvints
requested changes
Jan 8, 2025
| * @return \Laravel\Cashier\Checkout | ||
| */ | ||
| public function create($items, array $sessionOptions = [], array $customerOptions = []) | ||
| public function create($items, array $sessionOptions = [], array $customerOptions = [], $opts = null) |
There was a problem hiding this comment.
You still need to pipe this through to the create call.
driesvints
reviewed
Jan 8, 2025
| /** | ||
| * @phpstan-import-type RequestOptionsArray from \Stripe\Util\RequestOptions | ||
| * | ||
| * @psalm-import-type RequestOptionsArray from \Stripe\Util\RequestOptions |
There was a problem hiding this comment.
From Stripe\Service\Checkout::create($params = null, $opts = null) Can be array
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(Checkout): Add request option parameters