Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ports-of-call to latest master #234

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Conversation

jhp-lanl
Copy link
Collaborator

@jhp-lanl jhp-lanl commented Feb 27, 2023

PR Summary

Pretty straight-forward. Just update ports-of-call to the latest master.

This is needed to make full use of the portable errors.

PR Checklist

  • N/A Adds a test for any bugs fixed. Adds tests for new features.
  • N/A Format your changes by using the make format command after configuring with cmake.
  • N/A Document any new features, update documentation for changes made.
  • N/A Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • N/A If preparing for a new release, update the version in cmake.

@jhp-lanl
Copy link
Collaborator Author

@Yurlungur this just updates ports-of-call to avoid the undefined behavior we just fixed. This is necessary for
#233

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhp-lanl . I also updated the spackage, which may be required for the CI to pass on Darwin.

@rbberger I don't think it's urgent we update spack upstream, but eventually we should add v1.4.2 of ports-of-call upstream. It can probably wait until the next singularity-eos release though.

@Yurlungur
Copy link
Collaborator

@jhp-lanl and @rbberger if you're happy with the updated spackage, I'll click "merge."

Copy link
Collaborator

@rbberger rbberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need this in spiner

@Yurlungur
Copy link
Collaborator

Yes good point. I'll add it.

@Yurlungur
Copy link
Collaborator

lanl/spiner#61

@jhp-lanl
Copy link
Collaborator Author

@Yurlungur this looks good to go. I haven't merged yet in case you have any last minute additions

@Yurlungur Yurlungur merged commit 7916dc5 into main Feb 28, 2023
@Yurlungur Yurlungur deleted the jhp/update_ports_of_call branch February 28, 2023 01:10
@Yurlungur Yurlungur restored the jhp/update_ports_of_call branch February 28, 2023 01:11
@Yurlungur Yurlungur deleted the jhp/update_ports_of_call branch February 28, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants