Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vinet EOS implemented #202
Vinet EOS implemented #202
Changes from 10 commits
b7df57b
ec64f46
2df39fd
abb27be
d941a13
649e0b6
3b4464b
c380fe7
151da1a
1fcc814
a055997
da6fbc5
3ccaa68
9cf4c01
3227c21
b1f652a
af87cd6
8bed5df
bc5542a
be3852e
5b102f9
6ca8ec2
5a5bd42
d6c6f50
e848df9
2bac33a
3c0f2fa
77a2bf5
f050dde
63958a9
67f2254
63a9474
0f405e7
b0f3fd1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the comment no need to worry about this though. At least for now. We don't have to hook it into EOS builder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the code if it's not being included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the commented out code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine to leave or fine to remove. Slightly better to remove, but I consider this non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference is, assuming it stays, to put a
// TODO:
or some such comment that provides context to the commented out code. My preference is also for removal. I'm inclined to block if left in its current state (either remove or add context comment).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok let's just remove the commented out code then