-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] disambiguation.xml fix #10861
[pt] disambiguation.xml fix #10861
Conversation
Ahhhh... it now also fixes:
"militares" no longer appears as a verb. |
Sorry!!!!!!! I have just fixed it: If the words are not also nouns, it won't remove them as verbs. |
Now it is working again with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me.
Pedro, I am so stressed! 😛 😛 😛 😛 😛 😛 😛 Thanks! |
The rule seems tightly scoped, I doubt this will have many undesired side effects. But do keep an eye on the diff tomorrow morning. @susanaboatto probably wiser not to include this in a premium deployment, if it does happen later today (I know there may be some changes to the schedule, but just in case.) |
Yes, at 5am I will look at the diff to check if some exceptions need to be added. |
It worked better than expected: With such a positive experience, it seems I will “play” more with the disambiguation from now on 😛 😛 😛 😛 😛 😛 😛 I AM SO HAPPY!!!!! |
Heya, @susanaboatto , @p-goulart and @jaumeortola ,
I have fixed rare verbs detecting:
"garotas" and "partes" no longer appear as verbs.
But it will impact in the whole core of PT.
That is why I am always scared to change the disambiguator.
But if you believe it is okay, then it is a major improvement, and it will fix tons of false positives in our rules.