Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid occurring at least one message error when there was no user message for Claude llm #8789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dwgeneral
Copy link

@dwgeneral dwgeneral commented Sep 26, 2024

fix: avoid occurring at least one message error when there was no user message for Claude llm

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

The issue related is here

Fixes #8788

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Use Claude model without user message provided to run on workflow

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Sep 26, 2024
@laipz8200
Copy link
Collaborator

Is this plan usable when configuring with a system prompt and a user prompt?

@dwgeneral
Copy link
Author

Is this plan usable when configuring with a system prompt and a user prompt?

Yes, I tested the case too, that works fine as well.
Screenshot 2024-09-26 at 6 23 48 PM

@dwgeneral dwgeneral force-pushed the fix/authropic_model_at_least_error branch from cfc1169 to 3fd1f84 Compare September 27, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occurring at least one message error when there was no user message for Claude llm on workflow app
2 participants