-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: avoid implicit optional in type annotations of method #8727
Conversation
9be4f1c
to
fa547e5
Compare
db0eb86
to
3432be4
Compare
All the changes are applied and have been checked manually, including the imports and annotations. cc @laipz8200 |
api/core/rag/extractor/unstructured/unstructured_epub_extractor.py
Outdated
Show resolved
Hide resolved
api/core/model_runtime/model_providers/zhipuai/zhipuai_sdk/api_resource/files.py
Outdated
Show resolved
Hide resolved
...odel_runtime/model_providers/zhipuai/zhipuai_sdk/api_resource/knowledge/document/document.py
Outdated
Show resolved
Hide resolved
Hi @laipz8200 , may I raise a separate PR after this PR being merged , to resolve the comments you suggested which are not detected by the RUF013 rule and which of suggestions also indicates possible behaviour changes (e.g. removing unused parameters)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work.
Thanks for the detailed review. Will follow your comments later. |
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration