fix: Variable Aggregator Node supports parallel branching #8677
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
dosubot
bot
added
size:S
takatost
reviewed
Sep 23, 2024
Comment on lines
+24
to
+30
| if "output" not in outputs: | ||
| outputs["output"] = [] | ||
| if isinstance(variable, list): | ||
| outputs["output"].extend(variable) | ||
| elif isinstance(variable, str): | ||
| outputs["output"].append(variable) | ||
| inputs[".".join(selector[1:])] = variable |
There was a problem hiding this comment.
Would you pls explain the purpose of this codes?
There was a problem hiding this comment.
When the parallel branch calls the knowledge recall and then aggregates, the variable is a list, and the parameter aggregation variable after the ordinary if else node is a str.
There was a problem hiding this comment.
When the parallel branch calls the knowledge recall and then aggregates, the variable is a list, and the parameter aggregation variable after the ordinary if else node is a str.
Could you explain the problem you’re encountering? I'd like to understand the context and intent.
If possible, pls create an issue and link it to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax:
Fixes #<issue number>, see documentation for more details.Fixes
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration