fix(notion-extractor): guard against empty table row results#37836
Open
citizen204 wants to merge 1 commit into
Open
fix(notion-extractor): guard against empty table row results#37836citizen204 wants to merge 1 commit into
citizen204 wants to merge 1 commit into
Conversation
When Notion returns an empty results array for a table block's children, _read_table_rows() raised IndexError at data['results'][0]. Skip empty pages and continue pagination instead of crashing. Fixes langgenius#37817
dosubot
Bot
added
the
size:XS
Contributor
Pyrefly Type Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_read_table_rows()innotion_extractor.pyassumed Notion always returns at least one result when fetching table block children. When the API returns an emptyresultsarray, indexingdata['results'][0]raisedIndexError.This PR adds a guard that skips empty pages and continues pagination instead of crashing.
Fixes #37817
Changes
api/core/rag/extractor/notion_extractor.py: checkdata['results']is non-empty before accessing the first row; if empty, advance the cursor or mark done and continue