fix(trace): add explicit ids to Langfuse generation#37833
Open
MEGHADESAI5 wants to merge 1 commit into
Open
Conversation
dosubot
Bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds explicit observation IDs to Langfuse generation events created in:
message_tracesuggested_question_traceProblem
add_generation()sends generation events through the Langfuse ingestion API. WhenLangfuseGeneration.idis not provided,filter_none_values()removes the field and the resultingCreateGenerationBodyis created withid=None.This can result in generation observations being dropped by Langfuse, causing traces to be created without corresponding generation records.
Changes
id=str(uuid.uuid4())to generation creation inmessage_traceid=str(uuid.uuid4())to generation creation insuggested_question_traceRelated
Fixes #37824