fix: harden uploaded filename validation#37810
Open
xiaweiwei67-stack wants to merge 1 commit into
Open
Conversation
upload_file only rejected "/" and "\" in the original filename. That name is kept as display metadata (UploadFile.name) and can surface in ZIP entry names, Content-Disposition headers, and logs, so also reject NUL bytes, control characters (CR/LF etc. - header/log injection vectors), and the bare dot-names "." / "..". The storage key is already UUID-based, so this is defense-in-depth; the existing error message/behavior is unchanged. Adds a parametrized unit test covering the new rejections.
xiaweiwei67-stack
requested review from
QuantumGhost and
laipz8200
as code owners
dosubot
Bot
added
the
size:S
Contributor
Pyrefly Type Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileService.upload_fileonly rejected the path separators/and\in the original filename. That name is stored as display metadata (UploadFile.name) and can surface in ZIP entry names,Content-Dispositionheaders, and log lines.This additionally rejects NUL bytes, control characters (CR/LF etc. - header/log injection vectors), and the bare dot-names
./... The storage key is already UUID-based, so this is defense-in-depth, and the existingValueError("Filename contains invalid characters")message/behavior is unchanged. Legitimate names (spaces, accented/CJK characters,..as a substring such asv1..2.zip) are still accepted.Adds a parametrized unit test covering the new rejections. Verified with
ruff checkandruff formaton the changed files.Fixes #37809
Screenshots
N/A (backend input validation; no UI change).
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsFrom Cursor