fix: skip empty tool entries in agent_chat config validation#37775
Open
he-yufeng wants to merge 1 commit into
Open
fix: skip empty tool entries in agent_chat config validation#37775he-yufeng wants to merge 1 commit into
he-yufeng wants to merge 1 commit into
Conversation
Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
dosubot
Bot
added
the
size:XS
Contributor
Pyrefly Type Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_agent_mode_and_set_defaultsiteratesagent_mode["tools"]and immediately doeskey = list(tool.keys())[0], which raisesIndexErrorwhen a tool entry is an empty dict{}(e.g. from a malformed or legacy/migrated config), crashing config validation.This adds the same
if not tool: continueguard that was already merged for the siblingdataset/manager.py(#37669) and is present invariables/manager.py(#37671), so an empty tool entry is skipped instead of crashing. Added a unit test intest_agent_chat_app_config_manager.pycovering the empty-entry case (it raisedIndexErrorbefore, passes after).From Claude Code.