refactor: pass session as parameter in knowledge_retrieval_inner_service and agent_app_feature_service

[EvanYao826]

Summary

Migrate db.session usage to explicit session parameter in two service files, following the pattern established in #37402.

Changes

api/services/knowledge_retrieval_inner_service.py:

• Added session: scoped_session | None = None to retrieve()
• Added session: scoped_session to _validate_caller_app() and _validate_datasets()
• Replaced db.session with session in validation methods
• Updated controller caller to pass session=db.session explicitly

api/services/agent_app_feature_service.py:

• Added session: scoped_session | None = None to update_features()
• Replaced db.session.add/flush/commit with session.add/flush/commit
• Updated controller caller to pass session=db.session explicitly

Pattern

# Before
def retrieve(self, request: ...):
    app = db.session.scalar(select(App).where(...))

# After
def retrieve(self, request: ..., session: scoped_session | None = None):
    session = session or db.session
    app = session.scalar(select(App).where(...))

This makes the session dependency explicit while maintaining backward compatibility via the default None fallback.

Related

• make db.session pass from parameter. #37403
• Follows the pattern from chore: example to color the session #37402

[github-actions]

Pyrefly Type Coverage

Metric	Base	PR	Delta
Type coverage	50.84%	50.85%	+0.01%
Strict coverage	50.35%	50.36%	+0.01%
Typed symbols	29,966	29,967	+1
Untyped symbols	29,254	29,248	-6
Modules	2914	2914	0

[EvanYao826]

Thanks for the review @asukaminato0721! I've applied all four suggestions:

• Made session a required parameter (scoped_session instead of scoped_session | None = None)
• Removed the session = session or db.session fallback lines in both files

The callers already pass session=db.session explicitly, so no changes needed there.

[github-actions]

Pyrefly Diff

base → PR

--- /tmp/pyrefly_base.txt	2026-06-21 05:36:47.960388301 +0000
+++ /tmp/pyrefly_pr.txt	2026-06-21 05:36:33.433322587 +0000
@@ -6885,6 +6885,18 @@
   --> tests/unit_tests/services/test_human_input_file_upload_service.py:55:20
 ERROR `in` is not supported between `Literal['form_id=test-form']` and `None` [not-iterable]
    --> tests/unit_tests/services/test_human_input_service.py:547:12
+ERROR Missing argument `session` in function `services.knowledge_retrieval_inner_service.InnerKnowledgeRetrievalService.retrieve` [missing-argument]
+   --> tests/unit_tests/services/test_knowledge_retrieval_inner_service.py:104:61
+ERROR Missing argument `session` in function `services.knowledge_retrieval_inner_service.InnerKnowledgeRetrievalService.retrieve` [missing-argument]
+   --> tests/unit_tests/services/test_knowledge_retrieval_inner_service.py:175:50
+ERROR Missing argument `session` in function `services.knowledge_retrieval_inner_service.InnerKnowledgeRetrievalService.retrieve` [missing-argument]
+   --> tests/unit_tests/services/test_knowledge_retrieval_inner_service.py:192:54
+ERROR Missing argument `session` in function `services.knowledge_retrieval_inner_service.InnerKnowledgeRetrievalService.retrieve` [missing-argument]
+   --> tests/unit_tests/services/test_knowledge_retrieval_inner_service.py:199:54
+ERROR Missing argument `session` in function `services.knowledge_retrieval_inner_service.InnerKnowledgeRetrievalService.retrieve` [missing-argument]
+   --> tests/unit_tests/services/test_knowledge_retrieval_inner_service.py:207:54
+ERROR Missing argument `session` in function `services.knowledge_retrieval_inner_service.InnerKnowledgeRetrievalService.retrieve` [missing-argument]
+   --> tests/unit_tests/services/test_knowledge_retrieval_inner_service.py:218:54
 ERROR Object of class `ModelLoadBalancingService` has no attribute `provider_manager` [missing-attribute]
   --> tests/unit_tests/services/test_model_load_balancing_service.py:76:5
 ERROR Object of class `ModelLoadBalancingService` has no attribute `model_assembly` [missing-attribute]

[asukaminato0721]

=========================== short test summary info ============================
FAILED api/tests/unit_tests/services/test_knowledge_retrieval_inner_service.py::TestInnerKnowledgeRetrievalService::test_retrieve_maps_multiple_request_and_skips_enable_api_check - AttributeError: <module 'services.knowledge_retrieval_inner_service' from '/home/runner/work/dify/dify/api/services/knowledge_retrieval_inner_service.py'> does not have the attribute 'db'
FAILED api/tests/unit_tests/services/test_knowledge_retrieval_inner_service.py::TestInnerKnowledgeRetrievalService::test_retrieve_maps_single_request - AttributeError: <module 'services.knowledge_retrieval_inner_service' from '/home/runner/work/dify/dify/api/services/knowledge_retrieval_inner_service.py'> does not have the attribute 'db'
FAILED api/tests/unit_tests/services/test_knowledge_retrieval_inner_service.py::TestInnerKnowledgeRetrievalService::test_retrieve_raises_when_app_missing - AttributeError: <module 'services.knowledge_retrieval_inner_service' from '/home/runner/work/dify/dify/api/services/knowledge_retrieval_inner_service.py'> does not have the attribute 'db'
FAILED api/tests/unit_tests/services/test_knowledge_retrieval_inner_service.py::TestInnerKnowledgeRetrievalService::test_retrieve_raises_when_app_belongs_to_other_tenant - AttributeError: <module 'services.knowledge_retrieval_inner_service' from '/home/runner/work/dify/dify/api/services/knowledge_retrieval_inner_service.py'> does not have the attribute 'db'
FAILED api/tests/unit_tests/services/test_knowledge_retrieval_inner_service.py::TestInnerKnowledgeRetrievalService::test_retrieve_raises_when_dataset_missing - AttributeError: <module 'services.knowledge_retrieval_inner_service' from '/home/runner/work/dify/dify/api/services/knowledge_retrieval_inner_service.py'> does not have the attribute 'db'
FAILED api/tests/unit_tests/services/test_knowledge_retrieval_inner_service.py::TestInnerKnowledgeRetrievalService::test_retrieve_raises_when_dataset_belongs_to_other_tenant - AttributeError: <module 'services.knowledge_retrieval_inner_service' from '/home/runner/work/dify/dify/api/services/knowledge_retrieval_inner_service.py'> does not have the attribute 'db'
===== 6 failed, 12541 passed, 4 skipped, 535 warnings in 225.20s (0:03:45) =====

[EvanYao826]

Thanks for the review @asukaminato0721! All 4 suggestions have been applied:

1. agent_app_feature_service.py: session: scoped_session (removed | None = None)
2. agent_app_feature_service.py: Removed session = session or db.session fallback
3. knowledge_retrieval_inner_service.py: session: scoped_session (removed | None = None)
4. knowledge_retrieval_inner_service.py: Removed session = session or db.session fallback

The session parameter is now required in both files, and the controller callers already pass session=db.session explicitly.

[EvanYao826]

Hi @asukaminato0721, thanks for the review suggestions! I've addressed the session parameter style changes — in the follow-up PR #37793, I've switched to session: scoped_session (required, no default) for consistency with the pattern in #37402. The session = session or db.session fallback lines are also removed there.

Since this batch1 PR already has lgtm, I kept it as-is to avoid rebasing. The style unification is in batch2. Let me know if you'd like me to backport the changes here instead!