Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the HTTP request body is in JSON format, the request may fail if there are line breaks or unescaped double quotes. #13884

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

litterGuy
Copy link
Contributor

Summary

This change addresses an issue where HTTP requests with a JSON body fail due to the presence of line breaks or unescaped double quotes. The fix ensures that the JSON body is properly formatted, avoiding these issues.

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

litterGuy and others added 4 commits November 24, 2024 11:21
When the node sends an http request parameter with \n\t\r, the json conversion error ValueError: Invalid control character at: line 1 column 8363 (char 8362)
…il if there are line breaks or unescaped double quotes.
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Feb 18, 2025
@crazywoola crazywoola requested a review from laipz8200 February 18, 2025 07:26
@crazywoola
Copy link
Member

Please link an existing issue or open a new issue in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants