Conversation
Contributor
There was a problem hiding this comment.
LGTM
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add
tracing_enabledparameter to conditionally initialize tracing inLangfuseResourceManagerandLangfuseclient.tracing_enabledparameter toLangfuseResourceManagerandLangfuseconstructor._initialize_instance()inresource_manager.pyto conditionally initialize tracer and span processor based ontracing_enabled.client.py, passtracing_enabledtoLangfuseResourceManagerand useNoOpTracerif tracing is disabled.LangfuseResourceManager.__new__()to defaulttracing_enabledtoTrueif not specified.This description was created by
for ae7ca32. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Optimizes the Langfuse client by conditionally initializing OpenTelemetry tracing based on configuration, preventing unnecessary processor registration when tracing is disabled.
tracing_enabledparameter toLangfuseResourceManagerinlangfuse/_client/resource_manager.pyfor conditional tracing initializationLangfuseclient inlangfuse/_client/client.pyto properly propagate tracing configuration