Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust LANGFLOW_CONFIG_DIR to prevent permission error #6095

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

italojohnny
Copy link
Member

Fix permission issue and update docker-compose.yml

  • Adjusted LANGFLOW_CONFIG_DIR to prevent permission errors
  • Removed version field for Docker Compose v2 compatibility
  • Replaced expose with ports for better configuration consistency
  • Removed trailing whitespace for cleaner formatting

Fixes: #6008

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Feb 3, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 3, 2025
@italojohnny italojohnny enabled auto-merge February 3, 2025 20:03
@italojohnny italojohnny disabled auto-merge February 3, 2025 20:04
Comment on lines +22 to +23
ports:
- "5432:5432"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make this change? Expose is safer, isn't it?

Copy link
Member Author

@italojohnny italojohnny Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great question that brings up an important point about the philosophy behind Langflow. Expose is indeed "safer" in the sense that it restricts access to Docker's internal network, preventing accidental exposure. However, it also creates an additional hurdle for users who want to access Langflow from other machines on the network.

At the end of the day, this decision reflects a common trade-off in software design: should we prioritize restrictions to prevent misuse, or should we prioritize ease of use and trust the user to take responsibility?

Personally, as a user, I’d prefer something that works out of the box without extra configuration. With that in mind, I took the liberty of simplifying things a little here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose up is broken due to /app permission
2 participants