Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement get_or_create_default_folder for user folder management #6090

Merged
merged 6 commits into from
Feb 3, 2025

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Feb 3, 2025

Introduce a new function to ensure the default folder exists for users, replacing the previous method. This change streamlines folder creation logic across the application.

Related #6054

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 3, 2025
@github-actions github-actions bot added the bug Something isn't working label Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/backend/base/langflow/initial_setup/setup.py:780

  • Ensure that the new behavior introduced by the get_or_create_default_folder function is covered by tests.
async def get_or_create_default_folder(session: AsyncSession, user_id: UUID) -> FolderRead:
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 3, 2025
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 3, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 3, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 3, 2025
@ogabrielluiz ogabrielluiz disabled auto-merge February 3, 2025 17:19
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 3, 2025
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #6090 will improve performances by 10.79%

Comparing fix-psql-folder-error (eea0d45) with main (f8b08a4)

Summary

⚡ 1 improvements
✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_invalid_run_with_input_type_chat 18.8 ms 17 ms +10.79%

…dability and maintainability by chaining actions on page elements instead of using separate lines for each action
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 3, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit bdda781 Feb 3, 2025
36 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-psql-folder-error branch February 3, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants