fix: Improve path handling and type annotations in FaissVectorStoreComponent #6081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d file path handling 🐛 (faiss.py): fix issue with building vector store when persist_directory is not provided 🐛 (faiss.py): fix issue with loading FAISS index when index file does not exist 📝 (faiss.py): add type hints for search_documents method parameters and return value 📝 (faiss.py): remove unnecessary logging statements from search_documents method
dosubot
bot
added
the
size:M
…eld to ensure it is mandatory for the user to provide a value
github-actions
bot
added
bug
…rectory more efficiently 🔧 (faiss.py): refactor search_documents method to handle persist_directory more efficiently
github-actions
bot
added
bug
github-actions
bot
added
bug
github-actions
bot
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
FaissVectorStoreComponentclass in thesrc/backend/base/langflow/components/vectorstores/faiss.pyfile. These changes aim to improve the handling of file paths, enhance type annotations, and streamline the search functionality.Improvements to file path handling:
resolve_pathto resolve paths relative to the Langflow root.build_vector_storemethod to use the newresolve_pathmethod and ensure the directory exists before saving the FAISS index. [1] [2]Enhancements to type annotations:
search_documentsmethod fromlist[Data]toList[Data]for consistency with other type annotations.Streamlining search functionality:
search_documentsmethod by removing unnecessary logging and directly returning the search results.#6072