-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add JSON field extraction and enhanced URL validation #6051
Open
Cristhianzl
wants to merge
10
commits into
main
Choose a base branch
from
cz/url-improve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
enhancement
New feature or request
labels
Jan 31, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 31, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 31, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 31, 2025
…on by using dictionary unpacking instead of manual key-value pairs
♻️ (url.py): refactor JSON URL validation for better readability and consistency
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 31, 2025
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Jan 31, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 31, 2025
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Jan 31, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 31, 2025
…LComponent class ♻️ (url.py): refactor ensure_url method to simplify logic and improve readability 🐛 (url.py): fix error handling in URLComponent class for invalid JSON content
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Feb 1, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Feb 1, 2025
CodSpeed Performance ReportMerging #6051 will not alter performanceComparing Summary
|
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
URLComponent
class in thesrc/backend/base/langflow/components/data/url.py
file, primarily focusing on adding support for JSON format extraction from HTML content. The most important changes include importing thejson
module, updating the output format options, and implementing additional logic to handle JSON content.Enhancements to the
URLComponent
class:src/backend/base/langflow/components/data/url.py
: Imported thejson
module to handle JSON content.class URLComponent(Component)
: Updated theDropdownInput
options to include "JSON" and modified theinfo
attribute to reflect the new option.def ensure_url(self, string: str) -> str
: Added validation to ensure URLs ending with ".json" when the format is set to "JSON".def fetch_content(self) -> list[Data]
: Implemented logic to parse and validate JSON content, and to structure the data accordingly.