Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add JSON field extraction and enhanced URL validation #6051

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Cristhianzl
Copy link
Member

This pull request introduces enhancements to the URLComponent class in the src/backend/base/langflow/components/data/url.py file, primarily focusing on adding support for JSON format extraction from HTML content. The most important changes include importing the json module, updating the output format options, and implementing additional logic to handle JSON content.

Enhancements to the URLComponent class:

@Cristhianzl Cristhianzl self-assigned this Jan 31, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jan 31, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 31, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 31, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 31, 2025
…on by using dictionary unpacking instead of manual key-value pairs
♻️ (url.py): refactor JSON URL validation for better readability and consistency
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 31, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jan 31, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 31, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 31, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 31, 2025
…LComponent class

♻️ (url.py): refactor ensure_url method to simplify logic and improve readability
🐛 (url.py): fix error handling in URLComponent class for invalid JSON content
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 1, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 1, 2025
Copy link

codspeed-hq bot commented Feb 1, 2025

CodSpeed Performance Report

Merging #6051 will not alter performance

Comparing cz/url-improve (075a4b8) with main (f8b08a4)

Summary

✅ 9 untouched benchmarks

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant