Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds new JSON viewer #5407

Draft
wants to merge 58 commits into
base: main
Choose a base branch
from
Draft

feat: adds new JSON viewer #5407

wants to merge 58 commits into from

Conversation

anovazzi1
Copy link
Contributor

@anovazzi1 anovazzi1 commented Dec 23, 2024

The pr adds a new component called JsonEditor for editing JSON data. It replaces the previous JsonView component used for displaying JSON data. This change improves the functionality and user experience of the application.

@severfire
Copy link

Great thing to have!

@lucaseduoli lucaseduoli changed the title UpdateJsonView feat: adds new JSON viewer Jan 20, 2025
@lucaseduoli lucaseduoli marked this pull request as ready for review January 20, 2025 20:24
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jan 20, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 20, 2025
@lucaseduoli lucaseduoli self-assigned this Jan 20, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 20, 2025
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 20, 2025
@lucaseduoli lucaseduoli enabled auto-merge January 20, 2025 21:18
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 20, 2025
anovazzi1 and others added 7 commits January 21, 2025 17:39
This commit adds a new component called JsonEditor, which allows users to edit JSON data. The component uses the JSONEditor library and provides options for customizing the editor's appearance and behavior. It also includes functionality for updating the edited data and triggering a callback when the data changes. The component is initialized with an initial data object and can be updated with new data through props. The component is designed to be reusable and can be easily integrated into other parts of the application.
The commit adds a new component called JsonEditor for editing JSON data. It replaces the previous JsonView component used for displaying JSON data. This change improves the functionality and user experience of the application.
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 30, 2025
@ogabrielluiz ogabrielluiz removed the DO NOT MERGE Don't Merge this PR label Jan 31, 2025
…d type consistency; enhance apply_json_filter to ensure proper data processing and add comprehensive unit tests.
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 31, 2025
…ut class to utilize it; enhance apply_json_filter return type to Data.
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 3, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 4, 2025
…ove UI layout

♻️ (index.tsx): Refactor imports and code formatting for better readability and maintainability
🔧 (index.tsx): Update BaseModal component styles to improve UI layout and responsiveness
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 7, 2025
📝 (App.css): add styling for .jse-menu .jse-button.jse-group-button class
📝 (classes.css): add extra line at the end of the file for consistency
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 7, 2025
…g them to utf-8

♻️ (base.py): refactor options field in Output class to accept BaseModel, dict, or None for better flexibility and compatibility
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 7, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants