Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add fastapi to client extra #666

Merged

Conversation

dennisrall
Copy link
Contributor

Just a quickfix for #212.

It would be better not to have to install fastapi only for using the client, but in my opinion this is still better then getting errors when importing the RemoteRunnable after a pip install "langserve[client]".

Otherwise at least the readme should be updated.

Copy link

cla-bot bot commented May 27, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dennis Rall.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented May 27, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the username @dennisrall on file. In order for us to review and merge your code, please complete the Individual Contributor License Agreement here https://forms.gle/AQFbtkWRoHXUgipM6 .

This process is done manually on our side, so after signing the form one of the maintainers will add you to the contributors list.

For more details about why we have a CLA and other contribution guidelines please see: https://github.com/langchain-ai/langserve/blob/main/CONTRIBUTING.md.

@dennisrall dennisrall force-pushed the fix-installation-with-client-option branch from 5b80fa6 to e4c6646 Compare May 27, 2024 07:30
Copy link

cla-bot bot commented May 27, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the username @dennisrall on file. In order for us to review and merge your code, please complete the Individual Contributor License Agreement here https://forms.gle/AQFbtkWRoHXUgipM6 .

This process is done manually on our side, so after signing the form one of the maintainers will add you to the contributors list.

For more details about why we have a CLA and other contribution guidelines please see: https://github.com/langchain-ai/langserve/blob/main/CONTRIBUTING.md.

@cla-bot cla-bot bot added the cla-signed label Jun 10, 2024
@eyurtsev eyurtsev merged commit df3aa45 into langchain-ai:main Jun 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants