Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default model for Anthropic #655

Merged
merged 2 commits into from
May 21, 2024
Merged

set default model for Anthropic #655

merged 2 commits into from
May 21, 2024

Conversation

ccurme
Copy link
Contributor

@ccurme ccurme commented May 21, 2024

ChatAnthropic() raises ValidationError.

Also set model for ChatOpenAI where it appears alongside anthropic.

Best to be explicit about model, otherwise new defaults will cause unexpected changes.

@ccurme ccurme requested a review from eyurtsev May 21, 2024 17:37
Copy link

cla-bot bot commented May 21, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the username @ccurme on file. In order for us to review and merge your code, please complete the Individual Contributor License Agreement here https://forms.gle/AQFbtkWRoHXUgipM6 .

This process is done manually on our side, so after signing the form one of the maintainers will add you to the contributors list.

For more details about why we have a CLA and other contribution guidelines please see: https://github.com/langchain-ai/langserve/blob/main/CONTRIBUTING.md.

@eyurtsev eyurtsev merged commit bb74431 into main May 21, 2024
@eyurtsev eyurtsev deleted the cc/add_default_model_names branch May 21, 2024 17:41
@cla-bot cla-bot bot added the cla-signed label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants