Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth options for RemoteRunnable #46

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

kreneskyp
Copy link
Contributor

This PR adds support for most authentication scenarios to RemoteRunnable. It does this by exposing auth kwargs available in the httpx clients.

From the httpx source:

  • auth - (optional) An authentication class to use when sending requests.
  • headers - (optional) Dictionary of HTTP headers to include when sending requests.
  • cookies - (optional) Dictionary of Cookie items to include when sending requests.
  • verify - (optional) SSL certificates (a.k.a CA bundle) used to verify the identity of requested hosts. Either True (default CA bundle), a path to an SSL certificate file, an ssl.SSLContext, or False (which will disable verification).
  • cert - (optional) An SSL certificate used by the requested host to authenticate the client. Either a path to an SSL certificate file, or two-tuple of (certificate file, key file), or a three-tuple of (certificate file, key file, password).

Testing

  • what tests are needed?

@eyurtsev eyurtsev self-requested a review October 17, 2023 01:20
@eyurtsev
Copy link
Collaborator

eyurtsev commented Oct 17, 2023

@kreneskyp thanks! We're proxying variables here, not super worried about testing this at the moment for the options. Added ability to specify joint client kwargs as well so users can pass either option.

@eyurtsev eyurtsev merged commit e819e9c into langchain-ai:main Oct 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants