Nc/playground #19
Merged
Nc/playground #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nfcampos
commented
Oct 5, 2023
•
nfcampos
commented
- Figure out why the frontend is retrying the request endlessly on error
- Sort out the packaging of the js files in langserve releases
- Sort out the env vars
- update development instructions in readme
- Sort out the UI design
- Make text input fields multi-line
- Sort out config defaults not applying in Safari
nfcampos
force-pushed
the
nc/playground
branch
from
39650ec
to
5ebe24f
Compare
nfcampos
commented
Oct 5, 2023
nfcampos
commented
Oct 5, 2023
eyurtsev
reviewed
Oct 5, 2023
| local_file_path = os.path.join( | ||
| os.path.dirname(__file__), | ||
| "../langserve-playground/dist", | ||
| file_path or "index.html", |
There was a problem hiding this comment.
Is file path configurable to prototype with different variations of the UX?
There was a problem hiding this comment.
why is file path an input?
…r configuration and intermediate steps
nfcampos
force-pushed
the
nc/playground
branch
from
e3b62b0
to
85320dc
Compare
nfcampos
force-pushed
the
nc/playground
branch
from
a387544
to
7225efe
Compare
jacoblee93
force-pushed
the
nc/playground
branch
from
f1d8e3e
to
6210639
Compare
Co-authored-by: jacoblee93 <[email protected]> Co-authored-by: Eugene Yurtsev <[email protected]>
Add contributing.md. Inserting this in the root of the project, so it's easier to find. If folks feel strongly can put in in .github.
eyurtsev
approved these changes
Oct 19, 2023
| @@ -195,7 +196,7 @@ async def test_server_bound_async(app_for_config: FastAPI) -> None: | |||
|
|
|||
| # Test batch | |||
| response = await async_client.post( | |||
| f"/h{config_hash}/batch", | |||
| f"/c/{config_hash}/batch", | |||
There was a problem hiding this comment.
Yes I changed the url format for the configured endpoints
| ) | ||
| ) | ||
| chain = ( | ||
| RunnablePassthrough.assign(chat_history=(lambda x: "\n".join(x))) |
There was a problem hiding this comment.
ah it's fine didn't notice the custom input type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.