Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nc/playground #19

Merged
merged 62 commits into from
Oct 19, 2023
Merged

Nc/playground #19

merged 62 commits into from
Oct 19, 2023

Conversation

nfcampos
Copy link
Collaborator

@nfcampos nfcampos commented Oct 5, 2023

  • Figure out why the frontend is retrying the request endlessly on error
  • Sort out the packaging of the js files in langserve releases
  • Sort out the env vars
  • update development instructions in readme
  • Sort out the UI design
  • Make text input fields multi-line
  • Sort out config defaults not applying in Safari
poetry run python examples/chain/server.py
cd langserve-playground && yarn dev

local_file_path = os.path.join(
os.path.dirname(__file__),
"../langserve-playground/dist",
file_path or "index.html",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is file path configurable to prototype with different variations of the UX?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is file path an input?

@@ -195,7 +196,7 @@ async def test_server_bound_async(app_for_config: FastAPI) -> None:

# Test batch
response = await async_client.post(
f"/h{config_hash}/batch",
f"/c/{config_hash}/batch",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I changed the url format for the configured endpoints

)
)
chain = (
RunnablePassthrough.assign(chat_history=(lambda x: "\n".join(x)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an issue atm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah it's fine didn't notice the custom input type

@nfcampos nfcampos marked this pull request as ready for review October 19, 2023 14:51
@nfcampos nfcampos merged commit c50ec01 into main Oct 19, 2023
7 checks passed
@nfcampos nfcampos deleted the nc/playground branch October 19, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants