-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nc/playground #19
Nc/playground #19
Conversation
nfcampos
commented
Oct 5, 2023
•
edited by dqbd
Loading
edited by dqbd
- Figure out why the frontend is retrying the request endlessly on error
- Sort out the packaging of the js files in langserve releases
- Sort out the env vars
- update development instructions in readme
- Sort out the UI design
- Make text input fields multi-line
- Sort out config defaults not applying in Safari
39650ec
to
5ebe24f
Compare
local_file_path = os.path.join( | ||
os.path.dirname(__file__), | ||
"../langserve-playground/dist", | ||
file_path or "index.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is file path configurable to prototype with different variations of the UX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is file path an input?
…r configuration and intermediate steps
e3b62b0
to
85320dc
Compare
a387544
to
7225efe
Compare
f1d8e3e
to
6210639
Compare
Co-authored-by: jacoblee93 <[email protected]> Co-authored-by: Eugene Yurtsev <[email protected]>
Add contributing.md. Inserting this in the root of the project, so it's easier to find. If folks feel strongly can put in in .github.
@@ -195,7 +196,7 @@ async def test_server_bound_async(app_for_config: FastAPI) -> None: | |||
|
|||
# Test batch | |||
response = await async_client.post( | |||
f"/h{config_hash}/batch", | |||
f"/c/{config_hash}/batch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I changed the url format for the configured endpoints
) | ||
) | ||
chain = ( | ||
RunnablePassthrough.assign(chat_history=(lambda x: "\n".join(x))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an issue atm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah it's fine didn't notice the custom input type