Fix get_buffer_string to support modern tool_calls #33984
+60
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33970
Problem
The
get_buffer_string()function was still using the deprecatedfunction_callfield fromadditional_kwargs. Modern AI providers (OpenAI, Anthropic, Gemini, etc.) now use thetool_callsattribute instead, which meant tool call information couldn't be output for messages from these providers.Solution
Updated
get_buffer_string()inlibs/core/langchain_core/messages/utils.pyto:tool_callsover the deprecatedfunction_callfunction_callformatChanges
get_buffer_string()to check fortool_callsfirst, then fall back tofunction_calltest_get_buffer_string_with_tool_calls()- tests modern tool_calls formattest_get_buffer_string_tool_calls_priority()- verifies tool_calls takes prioritytest_get_buffer_string_with_function_call()to ensure backward compatibilityTesting
Verified the fix works correctly with:
All changes are in the
langchain-corepackage as specified in the issue.