Skip to content

openai[patch]: fix client caching when request_timeout is specified via httpx.Timeout #31698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Jun 21, 2025

Resolves #31697

Copy link

vercel bot commented Jun 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jun 21, 2025 7:16pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Jun 21, 2025
Copy link

codspeed-hq bot commented Jun 21, 2025

CodSpeed WallTime Performance Report

Merging #31698 will not alter performance

Comparing cc/httpx_timeout (1c65c42) with master (4ee6112)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Jun 21, 2025

CodSpeed Instrumentation Performance Report

Merging #31698 will not alter performance

Comparing cc/httpx_timeout (1c65c42) with master (4ee6112)

Summary

✅ 13 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: unhashable type: 'Timeout' when passing request_timeout=httpx.Timeout(...) to ChatOpenAI constructor
1 participant