Skip to content

groq: add support for accessing reasoning output from Groq models #31662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mdrxy
Copy link
Contributor

@mdrxy mdrxy commented Jun 18, 2025

Description: return reasoning output in additional_kwargs as reasoning_content
Issue: Resolves #31052

Warning: the test_reasoning_output_stream integration test fails sporadically? After a failure, re-running seems to always result in a run that passes. Unsure whether this is on our end or Groq's.

@mdrxy mdrxy requested a review from ccurme June 18, 2025 19:19
Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2025 10:24pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 18, 2025
Copy link

codspeed-hq bot commented Jun 18, 2025

CodSpeed Walltime Performance Report

Merging #31662 will not alter performance

Comparing mdrxy/groq-reasoning (1d4c0ed) with master (29e17fb)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Jun 18, 2025

CodSpeed Instrumentation Performance Report

Merging #31662 will not alter performance

Comparing mdrxy/groq-reasoning (1d4c0ed) with master (29e17fb)

Summary

✅ 13 untouched benchmarks

Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 18, 2025
@ccurme
Copy link
Collaborator

ccurme commented Jun 18, 2025

The streaming test seemed to pass consistently for me btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants