fix(agent): enable virtual_mode for default filesystem backend #331
+10
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the agent creates files with paths like
/research_plan.md, it tries to write to the root filesystem instead of the current working directory, resulting in errors:Root Cause
The default
FilesystemBackendinagent.pywas created withoutvirtual_mode=True:Without
virtual_mode=True, theFilesystemBackendtreats paths starting with/as absolute system paths rather than paths relative to the working directory.Solution
Enable
virtual_mode=Truefor the default backend:With this fix:
/research_plan.md→{cwd}/research_plan.md(sandboxed to working directory)/memories/file.md→ Still routes to agent directory via/memories/routeImpact
/file.txtbehave as users expect (relative to cwd)/memories/routing continues to work as beforeTesting
Verified with test script:
Without fix: