* force usage of node14 in arm64 qemu container

* investigate performance regressions * investigate performance regressions part 2 * force usage of node14 in arm64 qemu container
lando · Sep 28, 2023 · bb4dcfc · bb4dcfc
1 parent c898678
commit bb4dcfc
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 20 deletions.
diff --git a/.github/workflows/pr-func-tests.yml b/.github/workflows/pr-func-tests.yml
@@ -43,11 +43,14 @@ jobs:
           - x64
           - arm64
         node-version:
-          - 16
+          - "16"
         os:
           - linux
           - macos
           - win
+        pkg-version:
+          - "5.8.0"
+          - "5.8.1"
     steps:
       - name: Checkout action code
         uses: actions/checkout@v3
@@ -59,4 +62,5 @@ jobs:
           entrypoint: bin/test
           node-version: ${{ matrix.node-version }}
           os: ${{ matrix.os }}
+          pkg: ${{ matrix.pkg-version }}
           upload: false
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## v3.0.1 - [September 28, 2023](https://github.com/lando/pkg-action/releases/tag/v3.0.1)
+
+* Reverted `node-sync` do to extreme slowness using `node16` in `arm64` environment
+
 ## v3.0.0 - [September 28, 2023](https://github.com/lando/pkg-action/releases/tag/v3.0.0)
 
 ### New Features

diff --git a/action.yml b/action.yml
@@ -147,8 +147,6 @@ runs:
       if: inputs.test != 'true' && steps.pkg-action-internal.outputs.target-arch == 'arm64'
       uses: uraimo/run-on-arch-action@v2
       with:
-        env: |
-          RUNNER_DEBUG: "${{ env.RUNNER_DEBUG }}"
         arch: aarch64
         # @TODO: eventually we need to get this to work on ubuntu20.04 for build parity but we are using
         # 18.04 because it was easier to get working, apparently there is a bug in 20.04s gpg?
@@ -157,30 +155,20 @@ runs:
         # We need to install node and yarn "again" because they dont exist inside our build container
         install: |
           apt update && apt -y install curl
-          curl -fsSL "https://deb.nodesource.com/setup_${{ inputs.node-version }}.x" | bash -
+          curl -fsSL "https://deb.nodesource.com/setup_14.x" | bash -
           apt-get install -y nodejs
           curl -sL https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
           echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list
           apt update && apt -y install yarn
           yarn global add pkg@${{ inputs.pkg }} --prefix /usr/local
           pkg --version
         run: |
-          if [ "$RUNNER_DEBUG" == 1 ] || [ "$RUNNER_DEBUG" == "1" ]; then
-            pkg \
-            --config ${{ inputs.config }} \
-            --target=${{ steps.pkg-action-internal.outputs.target-node }}-${{ steps.pkg-action-internal.outputs.target-os }}-${{ steps.pkg-action-internal.outputs.target-arch }} \
-            --out-path dist \
-            --debug \
-            ${{ inputs.options }} \
-            ${{ inputs.entrypoint }}
-          else
-            pkg \
-            --config ${{ inputs.config }} \
-            --target=${{ steps.pkg-action-internal.outputs.target-node }}-${{ steps.pkg-action-internal.outputs.target-os }}-${{ steps.pkg-action-internal.outputs.target-arch }} \
-            --out-path dist \
-            ${{ inputs.options }} \
-            ${{ inputs.entrypoint }}
-          fi
+          pkg \
+          --config ${{ inputs.config }} \
+          --target=${{ steps.pkg-action-internal.outputs.target-node }}-${{ steps.pkg-action-internal.outputs.target-os }}-${{ steps.pkg-action-internal.outputs.target-arch }} \
+          --out-path dist \
+          ${{ inputs.options }} \
+          ${{ inputs.entrypoint }}
           stat ${{ steps.pkg-action.outputs.file }}
 
     - name: Upload ${{ steps.pkg-action.outputs.artifact-key }}