fix: build one partition at a time to avoid OOM #2484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we can build single HNSW graph in parallel, so don't need to build many partitions at a time. this still slows the building progress cause the IO operations (reading the shuffled files) can't be done in advance Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
eddyxu
reviewed
Jun 22, 2024
| @@ -296,8 +290,8 @@ pub(super) async fn write_hnsw_quantization_index_partitions( | |||
| let mut part_files = Vec::with_capacity(ivf.num_partitions()); | |||
| let mut aux_part_files = Vec::with_capacity(ivf.num_partitions()); | |||
| let tmp_part_dir = Path::from_filesystem_path(TempDir::new()?)?; | |||
| let mut tasks = Vec::with_capacity(ivf.num_partitions()); | |||
| let sem = Arc::new(Semaphore::new(*HNSW_PARTITIONS_BUILD_PARALLEL)); | |||
| let mut aux_ivf = IvfData::empty(); | |||
There was a problem hiding this comment.
is this the right name? why aux_ivf contains IvfData?
There was a problem hiding this comment.
aux_ivf is for tracking the storage partitions
eddyxu
reviewed
Jun 22, 2024
| if row_id_array.is_empty() { | ||
| tasks.push(tokio::spawn(async { Ok(0) })); | ||
| ivf.add_partition(offset, 0); |
There was a problem hiding this comment.
in v2, do we track the rows instead of byte offsets in index file?
There was a problem hiding this comment.
here offset is row offset, only IVF_PQ tracks the byte offsets.
all indices will track the row range in v2
| continue; | ||
| } | ||
| log::info!("Building HNSW partition {}", part_id); | ||
| let num_rows = build_hnsw_quantization_partition( |
There was a problem hiding this comment.
can we move this function to lance-index/src/hnsw?
|
#2552 can solve this problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can build single HNSW graph in parallel, so don't need to build many partitions at a time.
this still slows the building progress cause the IO operations (reading the shuffled files) can't be done in advance