fix: don't panic in IVF_PQ optimize if segments have different number of partitions #5313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, IvfModel::partition_size would panic when accessing a partition that doesn't exist in an index. This occurred during index optimization when multiple indices had different partition counts due to incremental partition splitting. The should_split function would iterate over all partitions based on the first index's partition count, then call partition_size on all existing indices, including older ones with fewer partitions. Changed partition_size to use .get().unwrap_or(0) instead of direct array indexing, returning 0 for non-existent partitions. Added regression test that verifies out-of-bounds accesses return 0 instead of panicking. Fixes lance-format#5312 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Added test_optimize_with_mismatched_partition_counts to verify that the full optimization pipeline handles indices with different partition counts without panicking. This test simulates the real-world scenario where incremental partition splitting creates indices with varying partition counts. The test: - Creates an initial IVF-PQ index with 4 partitions - Appends data and optimizes multiple times - Verifies optimization succeeds even with mismatched partition counts - Confirms the index remains functional after optimization 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
wjones127
force-pushed
the
fix-5312-partition-size-bounds
branch
from
eca4f1d to
a64adbc
Compare
wjones127
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
IvfModel::partition_sizewould panic when accessing a partition that doesn't exist in an index. This occurred during index optimization when multiple indices had different partition counts due to incremental partition splitting.Root Cause
The
should_splitfunction inbuilder.rs:1174-1177iterates over all partitions based on the first index's partition count, then callspartition_sizeon all existing indices, including older ones with fewer partitions. When partitions are split during optimization, newer indices can have more partitions than older ones (e.g., 116 → 117 → 118).Changes
IvfModel::partition_sizeto use.get().cloned().unwrap_or(0)instead of direct array indexingFixes #5312
🤖 Generated with Claude Code