-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic CELLxGENE workflow #75
base: main
Are you sure you want to change the base?
Conversation
|
||
# Analysis | ||
|
||
- Follow the Seurat tutorial to calculate marker genes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will take too much time. I'd not do something as comprehensive as this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have cell types so it should just be one function call to get the markers but happy to do something else. We could also have it as code that isn't run but then there will be no results to save.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! What you suggest sounds good!
# Analysis | ||
|
||
- Follow the Seurat tutorial to calculate marker genes | ||
- Save results as a text file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not use a text file but simply save an updated seurat object or alternatively a dataframe/parquet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data frame should be possible (I wrote this before I reminded myself how saving works). Saving a Seurat would probably require converting back to an AnnData if we are doing things through {reticulate}.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saving a Seurat would probably require converting back to an AnnData
Not necessarily. It's perfectly legit if an R team works with their Seurat objects internally as long as they don't expect an ML team to train on these artifacts.
|
||
# Add results | ||
|
||
- Add the results as an artifact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the previous step.
# Add results | ||
|
||
- Add the results as an artifact | ||
- Render and add report (?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to tell me but can we something like the following?
lamin save myanalysis.qmd
Meaning that you have a markdown-like file with everything in it.
The following would already work if the notebook contained Python code. I can make this work for a notebook that contains R but you should tell me whether that's necessary if we rather go with R markdown.
lamin save myanalysis.ipynb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use a .ipynb
to run code but I'm not sure we could add it to the current website (if that's the place). Also, it's not commonly used for R analysis. There is also Quarto which can be used for R and Python.
I'm not sure if we could run lamin save
inside the same document or if that would break. I don't know enough about how it all works to say what the best approach might be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it's not commonly used for R analysis.
Then this should be the last resort. We should use what's commonly used.
I don't know enough about how it all works to say what the best approach might be.
We should think about the best approach for an R user, not about what's easiest for lamin. I'll try to call you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lazappi and I just went on a call and hashed out the UX.
- The user exports their current
.qmd
or.rmd
session as an html with the same filename but the.html
suffix - The user runs
lamin save myanalysis.qmd
on the terminal
If the user forgets to export a .html
the CLI will raise an error and remind the user to do that manually.
) | ||
``` | ||
|
||
# Introduction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
- Save and upload results | ||
- Save and upload report (?) | ||
|
||
# Connect to a LaminDB instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
- Connect to CELLxGENE instance | ||
- Show instance object | ||
|
||
# Downloading a dataset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Add a vignette showing basic usage of the CELLxGENE instance