Skip to content

⬆️ Add compatibility with zarr v3 #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 26, 2025
Merged

⬆️ Add compatibility with zarr v3 #2711

merged 24 commits into from
May 26, 2025

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Apr 28, 2025

Closes #2335

This updates the internals of our code to support anndata>=0.12.0rc1 with zarr>=3.0.0.

lamindb still has anndata<=1.14.0 with zarr<3.0.0 in the requirements, but nothing breaks if newer anndata or zarr are installed.

Also refactors some zarr-related code.

@Koncopd
Copy link
Member Author

Koncopd commented Apr 28, 2025

Ok, from the side of lamindb the compatibility can be added without much problems.

@Koncopd Koncopd marked this pull request as draft April 28, 2025 13:34
@Koncopd Koncopd force-pushed the zarrv3_compat branch 2 times, most recently from f91b779 to b2c4f15 Compare April 29, 2025 11:39
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.13%. Comparing base (c081cbd) to head (aa2ae2e).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/core/storage/_zarr.py 76.19% 5 Missing ⚠️
lamindb/core/loaders.py 0.00% 1 Missing ⚠️
lamindb/core/storage/_anndata_accessor.py 85.71% 1 Missing ⚠️
lamindb/models/artifact.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2711      +/-   ##
==========================================
+ Coverage   91.94%   92.13%   +0.19%     
==========================================
  Files          70       71       +1     
  Lines       10717     9629    -1088     
==========================================
- Hits         9854     8872     -982     
+ Misses        863      757     -106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented May 22, 2025

Deployment URL: https://5e31f432.lamindb.pages.dev

@Koncopd Koncopd marked this pull request as ready for review May 26, 2025 09:27
@Koncopd Koncopd requested a review from falexwolf May 26, 2025 09:57
Copy link
Member

@falexwolf falexwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😄

@Koncopd Koncopd merged commit e1a18af into main May 26, 2025
18 of 19 checks passed
@Koncopd Koncopd deleted the zarrv3_compat branch May 26, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zarr 3 released today is not compatible with lamindb
2 participants