-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactor CellxGeneAnnDataCatManager
#2555
Conversation
CellxGeneAnnDataCatManager
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2555 +/- ##
==========================================
+ Coverage 92.15% 92.19% +0.04%
==========================================
Files 60 60
Lines 9988 9960 -28
==========================================
- Hits 9204 9183 -21
+ Misses 784 777 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Much better!
Moving much of this logic from a CatManager
to a Schema(name="CellxGene v5.1.2")
object can come in another PR.
We shouldn't need a CellxGeneCatManager
; all its logic should be persisted in a schema object and then understood by the AnnDataCurator()
.
CellxGeneAnnDataCatManager
CellxGeneAnnDataCatManager
CellxGeneAnnDataCatManager
CellxGeneAnnDataCatManager
exclude
inCatManager
classesCellxGeneAnnDataCatManager
so the previous test passes: 🚚 MoveCurator
tolamindb
cellxgene-lamin#120save_ulabels_parent
→save_ulabels_type
_get_categoricals_defaults()
→categoricals_defaults