Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Eliminate all logic related to using_key in curators #2414

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Feb 1, 2025

Is part of a sequence of PRs that refactors the curators:


Removing all logic related to using_key in curators is desirable because:

  1. it gives rise to a leaner definition of a "valid category" that no longer involves the state of another database, but is restricted to the state of the current database & well-defined public ontology versions
  2. it eliminates much code that makes refactoring easier

This is possible because PR 2412 eliminated the need for passing using_key for validating against the CellxGene schema, whose non-ontology based control values were its only motivation in the first place.

using_key was never a user-facing argument and hence its removal doesn't break backward compat.

@falexwolf falexwolf changed the title 🔥 Eliminate all logic pertaining to using-key in curators 🔥 Eliminate all logic pertaining to using_key in curators Feb 1, 2025
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.48%. Comparing base (d503387) to head (da2e7aa).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/curators/__init__.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2414      +/-   ##
==========================================
- Coverage   91.71%   91.48%   -0.23%     
==========================================
  Files          62       62              
  Lines        9138     9610     +472     
==========================================
+ Hits         8381     8792     +411     
- Misses        757      818      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@falexwolf falexwolf changed the title 🔥 Eliminate all logic pertaining to using_key in curators 🔥 Eliminate all logic related to using_key in curators Feb 1, 2025
Copy link

github-actions bot commented Feb 1, 2025

@github-actions github-actions bot temporarily deployed to pull request February 1, 2025 15:11 Inactive
@falexwolf falexwolf merged commit 2f674b7 into main Feb 1, 2025
17 of 18 checks passed
@falexwolf falexwolf deleted the refactorold branch February 1, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant