Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate logic of ontology_id and other registries better #206

Open
Zethson opened this issue Mar 4, 2025 · 0 comments
Open

Separate logic of ontology_id and other registries better #206

Zethson opened this issue Mar 4, 2025 · 0 comments

Comments

@Zethson
Copy link
Member

Zethson commented Mar 4, 2025

Our current implementation relies on attribute checks (hasattr for ontology_id, _ontology_id_field, _name_field) to differentiate ontology registries from other BioRecord registries. This approach lacks robustness as unique identifier fields vary across registry types (some ontologies use ontology_id while Genes use ensembl_gene_id or stable_id depending on organism). We need a more explicit architecture to properly distinguish between registry types and their unique constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant