Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate jsonExpressionFinder usage in Json view helper #97

Merged
merged 7 commits into from
Dec 30, 2021
Merged

Deprecate jsonExpressionFinder usage in Json view helper #97

merged 7 commits into from
Dec 30, 2021

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Dec 17, 2021

Q A
Documentation yes
BC Break no
New Feature kindof

Description

As per discussion about removing the dependency on laminas-json in #68 - This adds a deprecation warning when the relevant option is detected paving the way for removal in 3.0

@gsteel gsteel changed the title Triggers a deprecation error when JsonExpressionFinder option is used. Deprecate JsonExpressionFinder usage in Json View Helper Dec 17, 2021
@froschdesign froschdesign added this to the 2.16.0 milestone Dec 20, 2021
@gsteel
Docs CS Fix
7805313 
Signed-off-by: George Steel <[email protected]>
Ocramius
Ocramius approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of E_USER_DEPRECATED, but in this case, it is true that we can't do it in a different way, due to the deprecation being bound to a specific value combination, rather than a specific type.

@Ocramius Ocramius self-assigned this Dec 30, 2021
@Ocramius Ocramius merged commit cc803ea into laminas:2.16.x Dec 30, 2021
@Ocramius Ocramius changed the title Deprecate JsonExpressionFinder usage in Json View Helper Deprecate jsonExpressionFinder usage in Json view helper Dec 30, 2021
@Ocramius
Copy link
Member

Thanks @gsteel!

@gsteel gsteel deleted the deprecate-json-expr-finder branch December 30, 2021 12:33
@github-actions github-actions bot mentioned this pull request Dec 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froschdesign froschdesign froschdesign left review comments

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement Feature Removal
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gsteel @Ocramius @froschdesign