Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing tests for IDN TLD that contains uppercase #64

Open
wants to merge 2 commits into
base: 2.14.x
Choose a base branch
from
Open

Failing tests for IDN TLD that contains uppercase #64

wants to merge 2 commits into from

Commits on Jul 14, 2021

  1. Failing tests for TLD that contains uppercase

    @rugabarbo @weierophinney
    rugabarbo authored and weierophinney committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    ac7fe2e View commit details
    Browse the repository at this point in the history

  2. fix: use symfony/polyfill-mbstring to correct issues in Hostname vali… 

    …dator

This patch adds symfony/polyfill-mbstring as a requirement, and updates the `Hostname` validator to use mbstring equivalents of various string operations, where they are available.

Locally, one of the two new tests passes, but one original test ("UTF-8 label + UTF-8 TLD (cyrillic)") now fails — which may be a problem with my own locale.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
    @weierophinney
    weierophinney committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    ebaa162 View commit details
    Browse the repository at this point in the history