Refactor Extension and ExcludeExtension Validators
#355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteel
force-pushed
the
v3/file-extension-refactor
branch
from
79b4998
to
f9b6dec
Compare
- Remove compat with legacy `Laminas\File\Transfer` api - Remove all setters and getters - Adjust inheritance so both classes can be final - Only accept an options array to the constructor - Add new error message for completely invalid values (non-string, non-upload) instead of throwing an exception Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
v3/file-extension-refactor
branch
from
070be7b
to
7c74483
Compare
froschdesign
approved these changes
Jul 11, 2024
| } | ||
| $this->caseSensitive = $options['case'] ?? false; | ||
| $this->allowNonExistentFile = $options['allowNonExistentFile'] ?? false; | ||
| $this->extensions = self::resolveExtensionList($options['extension'] ?? []); |
There was a problem hiding this comment.
The same as before: the singular is okay.
|
Thank you @froschdesign 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Laminas\File\Transferapi