Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter and return types to ValidatorInterface::isValid() #297

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jun 28, 2024

Q A
BC Break yes
QA yes

Description

The main change here is changing the signature of ValidatorInterface::isValid() to public function isValid(mixed $value): bool;

The patch includes some other miscellaneous clean up:

  • Add property types to common props such as $messageTemplates
  • converts some protected static props to private constants

Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@gsteel gsteel self-assigned this Jul 2, 2024
@gsteel gsteel merged commit 8fafdd4 into laminas:3.0.x Jul 2, 2024
14 of 15 checks passed
@gsteel gsteel deleted the v3/is-valid-types branch July 2, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants