chore: Convert some parts of Date validator to php8 syntax and add some tests to check userland retrocompatibility. #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codisart
force-pushed
the
chore-date-validator-php8-syntax-non-BC
branch
from
01899b2
to
cba497b
Compare
codisart
force-pushed
the
chore-date-validator-php8-syntax-non-BC
branch
2 times, most recently
from
533d4f0
to
d77561a
Compare
…me tests to check userland retrocompatibility. Signed-off-by: codisart <[email protected]>
codisart
force-pushed
the
chore-date-validator-php8-syntax-non-BC
branch
from
d77561a
to
78d2570
Compare
Ocramius
reviewed
Feb 22, 2024
| use DateTimeInterface; | ||
| use Laminas\Validator\Date; | ||
|
|
||
| final class CustomDate extends Date |
There was a problem hiding this comment.
Let's document why we introduced this specific asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: codisart [email protected]
Description
It seems to me that the DateValidator would profit of the php8 syntax.
I have also added some tests to allow a check on userland breaking changes.