Fix ResponseInterface mocks so that getBody return streams instead …

…of strings Signed-off-by: George Steel <[email protected]>
laminas · May 19, 2023 · 490f16a · 490f16a
1 parent 393fc0c
commit 490f16a
Showing 1 changed file with 25 additions and 23 deletions.
diff --git a/test/UndisclosedPasswordTest.php b/test/UndisclosedPasswordTest.php
@@ -15,6 +15,7 @@
 use Psr\Http\Client\ClientInterface;
 use Psr\Http\Message\RequestFactoryInterface;
 use Psr\Http\Message\ResponseInterface;
+use Psr\Http\Message\StreamInterface;
 use ReflectionClass;
 use stdClass;
 
@@ -26,16 +27,11 @@
 
 final class UndisclosedPasswordTest extends TestCase
 {
-    /** @var ClientInterface&MockObject */
-    private ClientInterface $httpClient;
-
-    /** @var RequestFactoryInterface&MockObject */
-    private RequestFactoryInterface $httpRequest;
-
-    /** @var ResponseInterface&MockObject */
-    private ResponseInterface $httpResponse;
-
+    private ClientInterface&MockObject $httpClient;
+    private RequestFactoryInterface&MockObject $httpRequest;
+    private ResponseInterface&MockObject $httpResponse;
     private UndisclosedPassword $validator;
+    private StreamInterface&MockObject $stream;
 
     /** {@inheritDoc} */
     protected function setUp(): void
@@ -45,8 +41,8 @@ protected function setUp(): void
         $this->httpClient   = $this->createMock(ClientInterface::class);
         $this->httpRequest  = $this->createMock(RequestFactoryInterface::class);
         $this->httpResponse = $this->createMock(ResponseInterface::class);
-
-        $this->validator = new UndisclosedPassword($this->httpClient, $this->httpRequest);
+        $this->validator    = new UndisclosedPassword($this->httpClient, $this->httpRequest);
+        $this->stream       = $this->createMock(StreamInterface::class);
     }
 
     /**
@@ -114,7 +110,7 @@ public function testStrongUnseenPasswordsPassValidation(string $password): void
         $this->httpResponse
             ->expects(self::once())
             ->method('getBody')
-            ->willReturnCallback(function (): string {
+            ->willReturnCallback(function (): StreamInterface {
                 $hash = sha1('laminas-validator');
 
                 $constant = $this->getConstant(
@@ -123,11 +119,14 @@ public function testStrongUnseenPasswordsPassValidation(string $password): void
                 );
                 self::assertIsInt($constant);
 
-                return sprintf(
-                    '%s:%d',
-                    strtoupper(substr($hash, $constant)),
-                    random_int(0, 100000)
-                );
+                $this->stream->method('__toString')
+                    ->willReturn(sprintf(
+                        '%s:%d',
+                        strtoupper(substr($hash, $constant)),
+                        random_int(0, 100000)
+                    ));
+
+                return $this->stream;
             });
 
         $this->httpClient
@@ -148,7 +147,7 @@ public function testBreachedPasswordsDoNotPassValidation(string $password): void
         $this->httpResponse
             ->expects(self::once())
             ->method('getBody')
-            ->willReturnCallback(function () use ($password): string {
+            ->willReturnCallback(function () use ($password): StreamInterface {
                 $hash = sha1($password);
 
                 $constant = $this->getConstant(
@@ -158,11 +157,14 @@ public function testBreachedPasswordsDoNotPassValidation(string $password): void
 
                 self::assertIsInt($constant);
 
-                return sprintf(
-                    '%s:%d',
-                    strtoupper(substr($hash, $constant)),
-                    random_int(0, 100000)
-                );
+                $this->stream->method('__toString')
+                    ->willReturn(sprintf(
+                        '%s:%d',
+                        strtoupper(substr($hash, $constant)),
+                        random_int(0, 100000)
+                    ));
+
+                return $this->stream;
             });
 
         $this->httpClient