Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused laminas/laminas-log dependency #60

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jul 29, 2022

Q A
QA yes

Description

Saw this while reading laminas/technical-steering-committee#68

Removes laminas-log along with other minor chores.

@gsteel gsteel added this to the 4.1.0 milestone Jul 29, 2022
@Ocramius Ocramius self-assigned this Jul 29, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius merged commit 57010ac into laminas:4.1.x Jul 29, 2022
@gsteel gsteel deleted the remove-laminas-log branch July 29, 2022 07:25
@froschdesign
Copy link
Member

@gsteel
I think pull requests like these needs a better title because now we have the following in the release notes:

60: Remove laminas log thanks to @gsteel

But what does this means for the end user?

  • Has the logging feature been removed?
  • Does the user have to do or change anything?
  • What is the background of the change?
  • Or is there an alternative?

In the current case, nothing at all needs to be done, as an unused component has been removed. But this is not clear from the release notes or this pull request.

(The description of a milestone can also be used to add a detailed explanation, which is displayed in the release notes.)

@gsteel
Copy link
Member Author

gsteel commented Jul 29, 2022

I think pull requests like these needs a better title because now we have the following in the release notes:

Good point @froschdesign - Duly noted 👍

@Ocramius Ocramius changed the title Remove laminas log Removed unused laminas/laminas-log dependency Jul 29, 2022
@Ocramius
Copy link
Member

@froschdesign updated PR title and release notes - sorry, multitasking from the phone :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants