Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes HTML and CSS for navbar and toggler #76

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

Tyrsson
Copy link
Contributor

@Tyrsson Tyrsson commented May 23, 2023

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Tell us about why this change is necessary:
Changes address the Toggler issues in the skeleton layout and a style issue in the Laminas Navigation menu helper tutorial.

Review of changes.

  1. Removed an unnecessary div class="navbar-header" since bootstrap 5.2.3 does not support this class and the skeleton apps style.css does not target it either.
  2. Added a span wrapping the MVC Skeleton text with classes navbar-text text-light to improve the spacing of the text next to the logo.
  3. Changed the order of the markup so as to move the toggler to the right side and changed the collapse breakpoint to sm from md. The breakpoint is still triggered by simply shrinking the browser window.
  4. Added the needed style in style.css to allow the Laminas Navigation tutorial to work as stated in the docs. It targets specifically the .navbar li.active a so as to not style any other navigation items created by the navigation component. Seemed the least intrusive way to handle it.

Please reference the following:
Toggler:
https://getbootstrap.com/docs/5.2/components/navbar/#toggler

For the MVC Skeleton text:
https://getbootstrap.com/docs/5.2/components/navbar/#text-1

bumps breakpoint back to medium
Signed-off-by: Joey Smith <[email protected]>

Signed-off-by: Joey Smith <[email protected]>
@froschdesign froschdesign added the Bug Something isn't working label Jul 20, 2023
@froschdesign froschdesign changed the base branch from 2.3.x to 2.2.x July 20, 2023 14:57
@froschdesign froschdesign added this to the 2.2.1 milestone Jul 20, 2023
@froschdesign froschdesign changed the title Toggler fix Fixes HTML and CSS for navbar and toggler Jul 20, 2023
@Xerkus Xerkus changed the base branch from 2.2.x to 2.3.x December 6, 2023 11:47
@Xerkus Xerkus modified the milestones: 2.2.1, 2.3.0 Dec 6, 2023
@Xerkus Xerkus merged commit 56bdfa4 into laminas:2.3.x Dec 7, 2023
1 check passed
@Xerkus
Copy link
Member

Xerkus commented Dec 7, 2023

Thanks @Tyrsson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants