Add configCacheFileMode option #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mougrim <[email protected]>
mougrim
force-pushed
the
add-config-cache-file-mode-option
branch
from
9eafb8d
to
fac2175
Compare
|
This change needs tests to ensure file mode is picked up and applied properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tell us about why this change is necessary:
Config file can contain some secret information, which should not be readible for all users in server.
So I need to provide config file permission configCacheFileMode option, e.g. 0600.
Are you adding documentation?
Are you providing a QA improvement (additional tests, CS fixes, etc.) that
does not change behavior?
Are you fixing a BC Break?
Are you adding something the library currently does not support?
Are you refactoring code?