Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using FQN instead of aliases when referencing the NotEmpty validator internally #92

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Using FQN instead of aliases when referencing the NotEmpty validator internally #92

merged 1 commit into from
Jun 20, 2023

Conversation

vnccrl78
Copy link
Contributor

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

@vnccrl78
Using FQN instead of aliases
bbb9437 
Signed-off-by: Carlo Venco <[email protected]>
@Ocramius Ocramius added this to the 2.26.0 milestone Jun 20, 2023
@Ocramius Ocramius self-assigned this Jun 20, 2023
@Ocramius
Copy link
Member

Thanks @vnccrl78!

@Ocramius Ocramius changed the title Using FQN instead of aliases Using FQN instead of aliases when referencing the NotEmpty validator internally Jun 20, 2023
@Ocramius Ocramius merged commit d054b8f into laminas:2.26.x Jun 20, 2023
9 checks passed
@boesing
Copy link
Member

boesing commented Jun 20, 2023

FYI: this could be a regression as upstream could've registered a factory for that service name.
Just a sidenote here, but messing with service names in minors is not a good idea. I cant even see a reason for this as of now, did you guys chat on slack and this was a result or why do we need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Slamdunk Slamdunk Slamdunk approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
2.26.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vnccrl78 @Ocramius @boesing @Slamdunk