Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded .laminas-ci.json #53

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Remove unneeded .laminas-ci.json #53

merged 2 commits into from
Sep 4, 2023

Conversation

TimWolla
Copy link
Contributor

@TimWolla TimWolla commented Sep 4, 2023

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

All dependencies support PHP 8.3.

@TimWolla
Remove unneeded .laminas-ci.json
8e9c2cc 
All dependencies support PHP 8.3.

Signed-off-by: Tim Düsterhus <[email protected]>
@Ocramius Ocramius changed the base branch from 2.9.x to 2.10.x September 4, 2023 10:52
@Ocramius Ocramius added this to the 2.10.0 milestone Sep 4, 2023
@Ocramius
Copy link
Member

Ocramius commented Sep 4, 2023

Let's please also revert #52 then :)

@TimWolla
Copy link
Contributor Author

TimWolla commented Sep 4, 2023

Are you sure about this? I find it useful preserving the entry there, because I expect there will be future PHP versions where .laminas-ci.json might be reintroduced and folks are going to forget about re-adding the entry then.

@Ocramius
Copy link
Member

Ocramius commented Sep 4, 2023

If it's gone, it's gone: let's not leave a mucus trail behind :D

Distributing it is also not really a bug, just a minor nuisance.

TimWolla added a commit to WoltLab/laminas-httphandlerrunner that referenced this pull request Sep 4, 2023
@TimWolla
Revert "Mark .laminas-ci.json as export-ignore"
7a61e6c 
As per laminas#53 (comment)

This reverts commit 7708ee0.
@TimWolla
Revert "Mark .laminas-ci.json as export-ignore"
db6e921 
As per laminas#53 (comment)

This reverts commit 7708ee0.

Signed-off-by: Tim Düsterhus <[email protected]>
@TimWolla
Copy link
Contributor Author

TimWolla commented Sep 4, 2023 •
edited
Loading

If it's gone, it's gone: let's not leave a mucus trail behind :D

Okay reverted, discussing this is neither worth your, nor my time 😁

Distributing it is also not really a bug, just a minor nuisance.

Yeah. In my case we vendor all upstream dependencies and also review all upstream changes, because we want to know what we ship. Any additional file or change is annoying there. It also saves a (tiny) bit of traffic not including the file which generally is a good thing.

@Ocramius
Copy link
Member

Ocramius commented Sep 4, 2023

Thanks @TimWolla!

@Ocramius Ocramius merged commit 30b7553 into laminas:2.10.x Sep 4, 2023
14 checks passed
@Ocramius Ocramius self-assigned this Sep 4, 2023
@TimWolla TimWolla deleted the laminas-ci-unneeded branch September 4, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TimWolla @Ocramius