Remove deprecated filters #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If features are removed then this must be documented in a migration guide. - Migration:
- "Migration from Version 2 to 3": v3/migration/v2-to-v3.mdExample: https://docs.laminas.dev/laminas-form/v3/migration/v2-to-v3/ |
|
Is it best to revert docs changes here and move them to a |
|
@gsteel You are right, a revert and a separate pull request is the correct way. |
gsteel
force-pushed
the
remove-deprecated-filters
branch
2 times, most recently
from
7c7e4aa
to
677b5e4
Compare
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Instead of altering docs for the v2 series, new docs must be created and amended for the v3 series Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
remove-deprecated-filters
branch
from
677b5e4
to
92bf299
Compare
Signed-off-by: George Steel <[email protected]>
|
Any chance of an approval on this one? Everything is green 🙏 |
samsonasik
approved these changes
Jul 3, 2023
|
Thanks @samsonasik |
This was referenced Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the deprecated filters:
Cut from #101, so this will need a rebase and a 3.0 branch once that's merged.
Removing the dev dependency on laminas-crypt clears the way for testing this lib on laminas-servicemanger 4.x