PHP 8.3 support added #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Oct 10, 2023
Ocramius
approved these changes
Oct 10, 2023
Welcome |
| @@ -30,7 +30,7 @@ | |||
| "extra": { | |||
| }, | |||
| "require": { | |||
| "php": "~8.0.0 || ~8.1.0 || ~8.2.0" | |||
| "php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0" | |||
There was a problem hiding this comment.
@Ocramius
Do we really still need version 8 here?
There was a problem hiding this comment.
No, but that's for another patch/day 😁
There was a problem hiding this comment.
I always go with "unless there is no need to drop it, why drop it".
If it prevents us from doing stuff, feel free to drop it but I don't like this "lets drop it because we can drop it" out of no reason.
But might be personal preference tho.
There was a problem hiding this comment.
We're dropping 8.0 slowly but steadily, it's just a different changeset / can be done in a separate release :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description